search

mgomes / api_auth

HMAC authentication for Rails and HTTP Clients
MIT License
480 stars 147 forks source link

Add http.rb request driver #164

Closed tycooon closed 6 years ago

tycooon commented 6 years ago

For https://github.com/httprb/http gem.

fwininger commented 6 years ago

Looks good to me.

tycooon commented 6 years ago

I added specs for different HTTP gem versions, please take a look.

fwininger commented 6 years ago

Seems to be good. @mgomes don't forget to squash all the commit then you merge.

tycooon commented 6 years ago

@mgomes would be really cool to get this merged!

mgomes commented 6 years ago

@tycooon sorry for the delay in getting this one merged. Really appreciate your contribution, though. I am going to roll out version 2.2.0 after merging this in.

tycooon commented 6 years ago

@mgomes I see you released version 2.2.0 on rubygems but it doesn't include this PR for some reason.

mgomes commented 6 years ago

@tycooon sorry about that. Looks like I bungled the release. Please give 2.2.1 a go.