search

mgomes / api_auth

HMAC authentication for Rails and HTTP Clients
MIT License
480 stars 147 forks source link

Support Grape Api #169

Closed phuongnd08 closed 5 years ago

phuongnd08 commented 5 years ago

Grape is also a popular option to write API with Rails. This PR add out of the box support for app that use grape (https://github.com/ruby-grape/grape)

mgomes commented 5 years ago

@phuongnd08 thanks for this PR. I think Grape support would be welcomed by a lot of people. Could you add some test coverage for this driver? There are few other drivers you could use as a reference.

dunghuynh commented 5 years ago

@mgomes, I have added test for this driver and merged to master. However, the master branch build is failed. The test passed in my local development with rails_51.gemfile

mgomes commented 5 years ago

@dunghuynh thank you. @fwininger did some work to clean up the test suite on master. We just merged those changes in... Could you please merge master in again and see if that does the trick? 🙏

phuongnd08 commented 5 years ago

@fwininger All tests has passed now.