Fix unit tests pipeline and drop support for Ruby < 2.3

mgomes / api_auth

HMAC authentication for Rails and HTTP Clients

MIT License

480 stars 147 forks source link

Fix unit tests pipeline and drop support for Ruby < 2.3 #171

Closed fwininger closed 5 years ago

fwininger commented 5 years ago

Clean some code to fix the unit test pipeline.

According https://www.ruby-lang.org/en/downloads/branches/ I suggest to drop the support of Ruby < 2.3.

Please accept this PR to move forward !

fwininger commented 5 years ago

The gem http also drop the support of ruby < 2.3 (https://github.com/httprb/http)

fwininger commented 5 years ago

@mgomes can you merge this please ?

mgomes commented 5 years ago

@fwininger thanks for this! Do you think we should consider dropping support for Rails < 4.2 in the near future as well?

fwininger commented 5 years ago

@mgomes : thanks for this quick review. I agree to drop the support for Rails < 4.2 (like the Rails Team), but I suggest to drop the support only when it cause some troubles for this PR, like Ruby actually.