search

mh-cbon / gh-api-cli

Command line client for github api
http://mh-cbon.github.io/gh-api-cli/
MIT License
4 stars 2 forks source link

Dependent #6

Open suntong opened 7 years ago

suntong commented 7 years ago

Does gh-api-cli depend on any other go-github-release tools?

mh-cbon commented 7 years ago

I dont think so, it is self contained.

But yeah it has been designed while working with them, some of the tools in GGR are definitely integrating nicely with this one. The most noticeable is changelog.

suntong commented 7 years ago

k. thx.

suntong commented 7 years ago

FTR, from here, https://github.com/mh-cbon/go-github-release/issues/12#issuecomment-301711742, it seems that it depends on gump:

What does the notation of !newversion! or !isprerelease! mean? Should I use them literally?

Its a bump script, a script you run when you go from version A to version B. Those values are valid only within this file (https://github.com/mh-cbon/gump) They are used currently to put your assets on the right release version. But you might replace it with static values i guess, give it a try.

mh-cbon commented 7 years ago

hmmmmmm yes, no.

no because you might set the version manually. gump is only a bumper to make that happen via verbs rather than numbers.

You got to get the version name from somewhere, gump is one way, you might use a name generator https://github.com/dustinkirkland/golang-petname

mh-cbon commented 7 years ago

Note, currently there is one blocking point, indeed.

ver is required to be valid semver, https://github.com/mh-cbon/gh-api-cli/blob/12a88f8725038d7dda0bd71f7034b505d9963b55/dl/index.go#L111

At least for download command, I did not check the rest of the code.

Should not be a requirement, on the other hand semver named release allows range selection, names does not.

I ll keep it open, lets see.