search

mhammond / pywin32

Python for Windows (pywin32) Extensions
5.08k stars 801 forks source link

Adding support for IExchangeModifyTables for Rules and ACLs #1060

Closed ghost closed 7 years ago

ghost commented 14 years ago

This patch provides an implementation of the wrapping IExchangeModifyTable interface and the needed utility methods. The patch contains methods to wrap ROWLIST and ACTIONS structures and a set of flags to work with it. Please give me feedback if something is not conform to coding guidelines or other things to change.

Thanks Patrick

Reported by: marquies

Original Ticket: pywin32/patches/107

ghost commented 14 years ago

Original comment by: marquies

ghost commented 13 years ago

Sorry for the delay in looking at this.

Any chance this could be moved into the exchange module - it seems specific to exchange itself and I'm reluctant to have mapi itself include headers specific to the exchange SDK as I've been burnt before with mapi building but exchange failing.

Also, the addition of blank lines which aren't surrounded by other changes should be removed, and it appears OOF_TEXT isn't used so should be removed too.

Any reason you had to stick with integer literals instead of macro names in things like: + case 8: //OP_DELEGATE, + lpAction->acttype = OP_DELEGATE; ? OP_DELEGATE must exist as it is used in the following line.

+ printf ("Fatal Error, can not parse message ID"); Should set a Python error instead of a simple printf - ditto for a couple of other printfs.

The addition of EdkMdb.h etc worries me - the copyright statements don't say they are able to be copied - isn't this stuff in the exchange SDK?

Original comment by: mhammond

ghost commented 13 years ago

Hi Mark,

I'm glad that you respond this patch. I agree with you that this stuff is exchange specific and could be moved. Do you have a hint where to get the exchange sdk files to build the exchange extensions? I have installed this one [1] but I can't find the expected files to compile.

I would be pleased if we can fix this problem to continue the integration of this patch

[1] http://www.microsoft.com/downloads/details.aspx?familyid=4afe3504-c209-4a73-ac5d-ff2a4a3b48b7

Original comment by: marquies

ghost commented 13 years ago

If you get the latest from cvs and follow the instructions in setup.py, you should be able to get all the exchange modules building with just MSVC and the most recent platform SDK.

Original comment by: mhammond

ghost commented 13 years ago

Hi marquies, Are you still interested in re-working this as described?

Original comment by: mhammond

mhammond commented 7 years ago

Dupe of #981