mharris717 / ember-drag-drop

Drag and Drop Addon for Ember CLI
MIT License
204 stars 141 forks source link

Embroider compatibility problems #199

Open jacobq opened 2 years ago

jacobq commented 2 years ago

This addon (v0.9.0-beta.0) is currently blocking me from upgrading an app to ember 4.x / using embroider. I understand that the recommended path forward might be to migrate away from this addon though there might be soon be a replacement. Nevertheless, I ran into this, had to do some learning, and figured I ought to at least open a tracking issue so others can find this.

I made a fork to experiment and was hoping that the changes needed might be as simple as https://github.com/embroider-build/embroider#how-to-try-it but that doesn't seem to be the case, e.g. this CI build I don't know what object-bin is or is used for, but it looks like it used to be a component used in the test/dummy app and is now only vestigial. When I remove it that error goes away 🤷

`ember try:one embroider-safe` ``` === Scenario: embroider-safe =================================================== Successfully applied EMBROIDER_TEST_SETUP_OPTIONS=safe Building into C:\Users\jacob\AppData\Local\Temp\embroider\a6a245 Environment: test - building... [@embroider/webpack]assets by status 1.99 MiB [big] asset chunk.b83f2e021b012554d86b.js 1.17 MiB [emitted] [immutable] [big] (id hint: vendors) asset chunk.d65cc2c6f3033a38c4c6.js 573 KiB [emitted] [immutable] [big] (id hint: vendors) asset chunk.c7678aa2008cc6021f4f.js 267 KiB [emitted] [immutable] [big] asset chunk.cc79e722163f8b671114.js 76.2 KiB [emitted] [immutable] (name: assets/test.js) asset chunk.a210ec6d9a640c1d2661.js 7.36 KiB [emitted] [immutable] (name: assets/dummy.js) Entrypoint assets/dummy.js [big] 1.43 MiB = chunk.b83f2e021b012554d86b.js 1.17 MiB chunk.c7678aa2008cc6021f4f.js 267 KiB chunk.a210ec6d9a640c1d2661.js 7.36 KiB Entrypoint assets/test.js [big] 2.06 MiB = chunk.b83f2e021b012554d86b.js 1.17 MiB chunk.d65cc2c6f3033a38c4c6.js 573 KiB chunk.c7678aa2008cc6021f4f.js 267 KiB chunk.cc79e722163f8b671114.js 76.2 KiB runtime modules 6.73 KiB 13 modules modules by path ../../node_modules/ 1.12 MiB 251 modules modules by path ./ 138 KiB 68 modules modules by path ../../../ 250 KiB modules by path ../../../../../../../tmp/ember-drag-drop/node_modules/@babel/runtime/helpers/esm/*.js 1.63 KiB 4 modules + 3 modules modules by path ../../test-support/helpers/*.js 3.75 KiB ../../test-support/helpers/data-transfer.js 970 bytes [built] [code generated] + 2 modules modules by path ../../components/*.js 8.21 KiB ../../components/draggable-object-target.js 2.35 KiB [built] [code generated] + 2 modules ../../utils/proxy-unproxy-objects.js 1.49 KiB [built] [code generated] ../../services/drag-coordinator.js 5.31 KiB [built] [code generated] ../../mixins/droppable.js 3.48 KiB [built] [code generated] WARNING in ./tests/helpers/drag-drop.js 1:0-73 export 'default' (reexported as 'default') was not found in 'ember-drag-drop/test-support/helpers/drag-drop' (possible exports: drag) @ ./tests/test-support-import-test.js 2:0-52 10:46-57 @ ./assets/test.js 212:13-61 ERROR in ./components/object-bin.js 1:0-62 Module not found: Error: Can't resolve 'ember-drag-drop/components/object-bin' in '$TMPDIR\embroider\a6a245\tests\dummy\components' resolve 'ember-drag-drop/components/object-bin' in '$TMPDIR\embroider\a6a245\tests\dummy\components' Parsed request is a module using description file: $TMPDIR\embroider\a6a245\tests\dummy\package.json (relative path: ./components) Field 'browser' doesn't contain a valid alias configuration resolve as module $TMPDIR\embroider\a6a245\tests\dummy\components\node_modules doesn't exist or is not a directory looking for modules in $TMPDIR\embroider\a6a245\tests\dummy\node_modules existing directory $TMPDIR\embroider\a6a245\tests\dummy\node_modules\ember-drag-drop using description file: $TMPDIR\embroider\a6a245\tests\dummy\node_modules\ember-drag-drop\package.json (relative path: .) using description file: $TMPDIR\embroider\a6a245\tests\dummy\node_modules\ember-drag-drop\package.json (relative path: ./components/object-bin) no extension Field 'browser' doesn't contain a valid alias configuration $TMPDIR\embroider\a6a245\tests\dummy\node_modules\ember-drag-drop\components\object-bin doesn't exist .wasm Field 'browser' doesn't contain a valid alias configuration $TMPDIR\embroider\a6a245\tests\dummy\node_modules\ember-drag-drop\components\object-bin.wasm doesn't exist .mjs Field 'browser' doesn't contain a valid alias configuration $TMPDIR\embroider\a6a245\tests\dummy\node_modules\ember-drag-drop\components\object-bin.mjs doesn't exist .js Field 'browser' doesn't contain a valid alias configuration $TMPDIR\embroider\a6a245\tests\dummy\node_modules\ember-drag-drop\components\object-bin.js doesn't exist .json Field 'browser' doesn't contain a valid alias configuration $TMPDIR\embroider\a6a245\tests\dummy\node_modules\ember-drag-drop\components\object-bin.json doesn't exist .hbs Field 'browser' doesn't contain a valid alias configuration $TMPDIR\embroider\a6a245\tests\dummy\node_modules\ember-drag-drop\components\object-bin.hbs doesn't exist as directory $TMPDIR\embroider\a6a245\tests\dummy\node_modules\ember-drag-drop\components\object-bin doesn't exist $TMPDIR\embroider\a6a245\tests\node_modules doesn't exist or is not a directory looking for modules in $TMPDIR\embroider\a6a245\node_modules $TMPDIR\embroider\a6a245\node_modules\ember-drag-drop doesn't exist $TMPDIR\embroider\node_modules doesn't exist or is not a directory $TMPDIR\node_modules doesn't exist or is not a directory C:\Users\jacob\AppData\Local\node_modules doesn't exist or is not a directory C:\Users\jacob\AppData\node_modules doesn't exist or is not a directory C:\Users\jacob\node_modules doesn't exist or is not a directory C:\Users\node_modules doesn't exist or is not a directory C:\node_modules doesn't exist or is not a directory @ ./assets/dummy.js 95:13-52 webpack 5.69.1 compiled with 1 error and 1 warning in 5425 ms cleaning up... Build Error (PackagerRunner) in components\object-bin.js Module not found: Error: Can't resolve 'ember-drag-drop/components/object-bin' in '$TMPDIR\embroider\a6a245\tests\dummy\components\object-bin.js' ```
basz commented 2 years ago

yes, same for me... Any news on the planned replacement addon menitioned in https://github.com/mharris717/ember-drag-drop/releases/tag/v0.9.0-beta.0?