search

mhe / pynrrd

Simple pure-python module for reading and writing nrrd files.
https://pynrrd.readthedocs.io/
MIT License
116 stars 51 forks source link

Relative data file path printing #79

Closed tashrifbillah closed 5 years ago

tashrifbillah commented 5 years ago

Fixes #78

addisonElliott commented 5 years ago

We might want to add some tests to fully verify that the new parameter is working as expected.

codecov-io commented 5 years ago

Codecov Report

Merging #79 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #79   +/-   ##
=======================================
  Coverage   88.12%   88.12%           
=======================================
  Files           6        6           
  Lines         362      362           
  Branches      117      117           
=======================================
  Hits          319      319           
  Misses         21       21           
  Partials       22       22
Impacted Files Coverage Δ
nrrd/writer.py 87.17% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c1c42d9...d820b43. Read the comment docs.

tashrifbillah commented 5 years ago

Added tests, two for absolute path, two for relative path. Basically, I modified the existing detached header writing tests in a clever way that encompasses new tests.

cc: @ihnorton

addisonElliott commented 5 years ago

@tashrifbillah No problem, we're all busy so I understand if it takes you some time.