mher / flower

Real-time monitor and web admin for Celery distributed task queue
https://flower.readthedocs.io
Other
6.5k stars 1.09k forks source link

Hyperlink to tasks page in workers view does not respect the url prefix #1307

Closed estraph closed 1 year ago

estraph commented 1 year ago

Describe the bug On the workers overview page, there is a hyperlink to the total tasks which - unlike the main navigation menu - does not consider the url_prefix configuration. Clicking it returns a 404 error.

To Reproduce Steps to reproduce the behavior:

  1. Define a custom url_prefix, e.g. foo
  2. Navigate to /workers page
  3. Notice that the main navigation tasks link targets /foo/tasks
  4. Notice that the hyperlink on the total sum of tasks targets /tasks (without /foo)
  5. Clicking the total sum link returns a 404 error

Expected behavior When setting a url_prefix I would expect every hyperlink to flower pages to include the prefix in the URLs and not 404.

Screenshots In this example, I have a url_prefix of flower. Notice that the main nav respects this and works as expected:

However, the other link on the workers page does not:

System information This is flower 2.0.0 running on python 3.11.3 in an official python docker container (x86).

mher commented 1 year ago

Thanks for the bug report. Feel free to open a pull request.

mvaled commented 1 year ago

This was fixed in https://github.com/mher/flower/pull/1297

estraph commented 1 year ago

Very cool - thank you @mher @onyx-flame 🚀