search

mholt / caddy-ratelimit

HTTP rate limiting module for Caddy 2
Apache License 2.0
255 stars 17 forks source link

Distributed Retry-After #22

Closed plunkettscott closed 11 months ago

plunkettscott commented 1 year ago

I almost filed a bug report because after trying a few storage modules with distributed rate limits, the Retry-After was always being set to 0. I dug into the code and see that this is actually a static value.

Any ideas on how we can finish implementing Retry-After for distributed zones? I understand this probably isn't a very high priority feature for you, however, I'd be willing to work on it if there's some form of calculation you have in mind for the value.

mholt commented 1 year ago

Hi, good question! It's been a while since I've looked at this code so I'll need to make some time and get in the headspace to figure out a solution. (If a company needs this sooner rather than later, we can arrange a sponsorship and I'll prioritize it.) Otherwise, I'd welcome a proposal and/or PR!

mholt commented 11 months ago

@plunkettscott Done in #34 thanks to a contribution :)