search

mhoofman / wordpress-heroku

Template project for deploying WordPress to Heroku
Other
1.3k stars 702 forks source link

Setting WP_USE_EXT_MYSQL now allows new builds to work on heroku #90

Closed andysprout closed 10 years ago

andysprout commented 10 years ago

Potentially fixes issue #89

andysprout commented 10 years ago

To be honest I'm not a wordpress expert, so I don't fully understand the implications of the WP_USE_EXT_MYSQL setting, I just read the source of version 4.0 and it looked like this would fix the errors I was getting when running locally with MAMP, then after reading https://discussion.heroku.com/t/solved-php-legacy-buildpack/580/5 it seemed related, so I gave it a go and it seems to have fixed #89

mhoofman commented 10 years ago

This didn't fix the problem for #89.

Did f96d36a9072605472ef162ae6c9c837152386696 fix or cause issues with running WordPress locally?

andysprout commented 10 years ago

without f96d36a I was not able to run locally with MAMP, I tested this fix a few hours ago and was able to deploy to a fresh heroku app, but I only tested without the legacy build pack.

mhoofman commented 10 years ago

This does appear to fix deploy on the default PHP heroku buildpack. It prevents the use of mysqli commands with a later version of PHP.