mhostetter / gr-sqlite

GNU Radio OOT module for writing to and reading from SQLite databases
GNU General Public License v3.0
8 stars 4 forks source link

sqlite_triggered_source.xml file_save should be file_open #3

Closed potto216 closed 5 years ago

potto216 commented 5 years ago

When I use the triggered source component and selected a database to playback, the component said the database would be be overwritten. I changed file_save to file_open and then the message went away. As a side note where can you find GNURadio documentation on the types file_save and file_open? The closest I could find is https://wiki.gnuradio.org/index.php/GNURadioCompanion which wasn't very detailed.

mhostetter commented 5 years ago

Good catch. If you'd like to submit a PR, I'll happily merge it. Otherwise, I can make the change.

As for GNU Radio documentation, agreed. Some places can be spotty. I've honestly found searching github for keywords and code snippets to be successful. Also looking through other known-good out-of-tree modules can turn up hidden features. I believe that's how I discovered the <type>file_save</type> tag.

potto216 commented 5 years ago

Sounds good, I'll submit a PR

On Mon, Jul 29, 2019 at 10:34 AM Matt Hostetter notifications@github.com wrote:

Good catch. If you'd like to submit a PR, I'll happily merge it. Otherwise, I can make the change.

As for GNU Radio documentation, agreed. Some places can be spotty. I've honestly found searching github for keywords and code snippets to be successful. Also looking through other known-good out-of-tree modules can turn up hidden features. I believe that's how I discovered the

file_save tag. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub , or mute the thread .