search

mhowlett / NNanomsg

.NET binding for nanomsg
MIT License
179 stars 52 forks source link

Avoid dependency on debug version of MSVCRT #10

Closed kwpatrick closed 10 years ago

kwpatrick commented 10 years ago

The current Windows build of nanomsg.dll depends on msvcrt110d.dll, which can't be redistributed. The MSVCRT could be statically linked, or the release version could be referenced. Ideally, statically linking against the release version would make for the easiest distribution, if it doesn't increase library size too dramatically.

Also, do we have a process for building nanomsg with nn_poll included?

mhowlett commented 10 years ago

Ahh yes, the distribution issue slipped my mind.

martin finally added an nn_poll to nanomsg (not sure from your text if you picked up on that). Anyway, yeah, it would be good to at least document how to build the nanomsg libraries - I was stumped for a bit working out how to get any x64 nanomsg.dll built (need to specify the generator parameter in cmake when making the projects).

Matt.

btw, i'm unlikely to have time to look at anything for the next a week at least.

On Sun, Dec 8, 2013 at 2:57 AM, MasonOfWords notifications@github.comwrote:

The current Windows build of nanomsg.dll depends on msvcrt110d.dll, which can't be redistributed. The MSVCRT could be statically linked, or the release version could be referenced. Ideally, statically linking against the release version would make for the easiest distribution, if it doesn't increase library size too dramatically.

Also, do we have a process for building nanomsg with nn_poll included?

— Reply to this email directly or view it on GitHubhttps://github.com/mhowlett/NNanomsg/issues/10 .

kwpatrick commented 10 years ago

Nope, I hadn't seen that yet, I thought it was being statically linked in. It helps to pay attention! Awesome news, I'm glad he's owning the polling.

I'll update my nanomsg version and see what I can do. The x64 build took some work, and if I get it done again I'll try and post a list of instructions (or submit updates to the makefile/csproj).

kwpatrick commented 10 years ago

I haven't had any issue with:

cmake . -G "Visual Studio 11 Win64"

If you've already done a build, you'll have to remove the CMakeCache.txt file that was generated, as otherwise it'll complain about the change in generators.

I might have some fortunate things in my environment variables, so let me know if that still doesn't work. I feel like I had a few more steps last time, but Martin could've fixed some things in his makefiles.

mhowlett commented 10 years ago

I believe this is fixed now.