search

miasma-rb / miasma-aws

Miasma AWS API
Other
8 stars 8 forks source link

Prevent overrides by defaults #49

Closed chrisroberts closed 6 years ago

chrisroberts commented 6 years ago

Fixes #48

grosser commented 6 years ago

this breaks our setup somehow ...

TypeError: no implicit conversion of nil into String
miasma-aws-0.3.18/lib/miasma/contrib/aws.rb:97:in `digest'
miasma-aws-0.3.18/lib/miasma/contrib/aws.rb:97:in `sign'
...
sfn-3.0.32/lib/sfn/command/validate.rb:24:in `execute!'

bringing back

          creds.keys.each do |key|
            if creds[key] && new_creds[key].nil?
              new_creds[key] = creds[key]
            end
          end

fixes it

keys are: aws_profile_name, aws_bucket_region, aws_region

how about a whitelist for these so they still get copied ?