mibutec / popperfw

Declarative PageObjects for Java
Apache License 2.0
3 stars 3 forks source link

Upgrade compatibility to Java 17 #16

Closed StitzL closed 2 years ago

StitzL commented 2 years ago

It should become possible to use PopperFW as a library when tests are run on Java 8, 11, or 17. Currently, it is unknown if PopperFW (and its dependencies) can run on Java 17.

mibutec commented 2 years ago

Just tried out to build and run test latest version of Popperfw on Java 17:

ClassForge is used in BuildFramework, so guess Tests using this will also fail with Java 17. Test just using PagoObjects should be fine, We will provide a fix making ClassForge also run on Java 17. I'll discuss this next week in Testing Guild to get timing done. Any on timing requirements beside asap?

StitzL commented 2 years ago

No, not that I am aware of. But I think we will have to update the dependencies as well before working on PopperFW code properly. If you like to see that done in separate tasks, I could create some - for Mockito, Javassist, JGraphT, and probably some of the others.

team-magellan commented 2 years ago

This is a showstopper for all Java 17 update activities - no tests possible until this is resolved

team-magellan commented 2 years ago

To fix forge, look at this: https://stackoverflow.com/questions/69264559/javassist-with-jdk-17 works for me

StitzL commented 2 years ago

Feel free to open a PR! Just let me know if you need some help with that.

team-magellan commented 2 years ago

I also have a fix for PageObjectImplementation, it's trivial. Creating a PR.

team-magellan commented 2 years ago

PR created: https://github.com/mibutec/popperfw/pull/19

mibutec commented 2 years ago

merged

team-magellan commented 2 years ago

Please reopen since there are more failures of same kind on other places in code.

mibutec commented 2 years ago

When there is something not found by existing tests, please also add a reproducer test

team-magellan commented 2 years ago

PR created, with tests

StitzL commented 2 years ago

Closed by #22.