micasense / imageprocessing

MicaSense RedEdge and Altum image processing tutorials
https://www.micasense.com
MIT License
257 stars 152 forks source link

Add save_capture_as_bands() method. Add out_data_type parameter. #154

Closed and-viceversa closed 3 years ago

and-viceversa commented 3 years ago

The scope of this PR was a little broader than expected.

The unanticipated challenge when allowing multiple output data types is that handling the img_type is None case creates too many logical branches and the standard if else clutter for no real benefit. The simplest thing to do was change img_type from a kwarg to a positional argument. Forcing the choice works because there are only 2 potential outputs, and handling the None case with available data just felt like it added confusion especially in the higher level ImageSet.

This PR:

and-viceversa commented 3 years ago

This may close #121 and the final requirements for #77.