search

micha149 / gulp-maven-deploy

Gulp wrapper for the maven-deploy plugin
MIT License
12 stars 11 forks source link

Supports Gulp 4 #19

Closed sylvainpolletvillard closed 6 years ago

sylvainpolletvillard commented 6 years ago

Hi, I know it's an old project and you probably moved to something else. Anyway, it's worth asking: could you update this project to support Gulp 4 ? We have been waiting for Gulp 4 for years, and now that it is finally here, this is the last plugin in my toolchain that needs to be updated. I would be glad to help but I am afraid my knowledge of gulp internals is quite limited :worried:

micha149 commented 6 years ago

You are right. I personally don't use this module any more, because I am currently not deploying to a maven repository. I also didn't use gulp for a long time, so what is changed that this module will not work anymore?

Can you send a Pull Request with the necessary changes?

sylvainpolletvillard commented 6 years ago

I wish I could do that but it's hard to find documentation about how to upgrade plugins, and gulp 4 development has taken way too long. Hopefully someone with the required knowledge and motivation will come one day. Thanks for your response, have a nice day

micha149 commented 6 years ago

What error do you get?

sylvainpolletvillard commented 6 years ago

Unhandled promise rejection (rejection id: 1): TypeError: file.pipe is not a function

I try to look at other gulp plugins repos to see how they upgraded

related: https://github.com/gulpjs/gulp/issues/2091

micha149 commented 6 years ago

OK, I got it. The problem is, that on gulpjs/vinyl the pipe method was removed.

micha149 commented 6 years ago

Should be fixed with v1.0.2