micha149 / gulp-maven-deploy

Gulp wrapper for the maven-deploy plugin
MIT License
12 stars 11 forks source link

Invalid docs for configuration #2

Closed leftieFriele closed 10 years ago

leftieFriele commented 10 years ago

from @mythx: "When i used your module gulp-maven-deploy, i read your documentation but I think you forgot the settings in the configuration. I had to look at your source code to run properly deploy part.

In your example when you would maven.deploy you have section 'config' but we need section 'repositoryId' and 'snapshot'. It's important :)."

leftieFriele commented 10 years ago

the module just works with the install right now and not deploy.

MythX commented 10 years ago

the module works with the deploy with this config :

gulp.src('.')
    .pipe(maven.deploy({
        'config': {
            'groupId': 'myGroupId',
            'type': 'zip',
            'repositories': [
                {
                    'id': 'repoId',
                    'url': 'urlRepo'
                }
            ]
        },
        'deploy': true,
        'repositoryId': 'repoId',
        'snapshot': false
    }));
leftieFriele commented 10 years ago

Turned out the version I pushed to git and npm was just messed up. I cleaned it up and added better tests in the 0.1.0 version. The docs and code should be aligned now.