search

micha149 / gulp-maven-deploy

Gulp wrapper for the maven-deploy plugin
MIT License
12 stars 11 forks source link

Made gulp callbacks work #4

Closed Lukewh closed 9 years ago

Lukewh commented 9 years ago

The way the module was written didn't allow for task chaining e.g.

gulp.task('default', ['build', 'maven', 'anotherthing']);

anotherthing would always execute, even if maven failed.

leftieFriele commented 9 years ago

Good call, thanks for the PR. The tests broke with your change it seems, I'll merge once they pass.

Lukewh commented 9 years ago

:+1: All working :wink:

leftieFriele commented 9 years ago

Great stuff! Thanks for fixing this.