search

michaelWuensch / BitBanana

Lightning Node Management for Android
https://bitbanana.app
MIT License
104 stars 11 forks source link

Unable to use coinbase as rate provider #97

Open sha-265 opened 3 weeks ago

sha-265 commented 3 weeks ago

Description

When selecting coinbase as rate provider, the currency list is still mempool's list

Expected Behavior

load currencies list from Coinbase.

Actual Behavior

still using mempool list

Possible Fix

Steps to Reproduce

  1. choose Coinbase as rate provider
  2. try to add a currency that is available only on coinbase
  3. see if it missing

Context

I'm unable to choose different curencies from Coinbase, that are missing from mempool.

Your Environment

michaelWuensch commented 2 weeks ago

@sha-265 Do you have tor enabled in the settings? If yes, this might cause it as cloudflare often blocks requests coming from tor exit nodes.

sha-265 commented 2 weeks ago

@michaelWuensch yep, disabling Tor fixed the problem. maybe you should spilt this setting for rate provider, so I can use Tor for the other things. or add a rate provider with more currencies that not blocking tor. thanks

michaelWuensch commented 2 weeks ago

@sha-265 I have to reimplement tor anyway before I can release the next version as the current library is no longer compatible with the now required API level. I'll keep this in mind and maybe make a Tor settings page where you can turn on and off tor for specific things.

sha-265 commented 1 week ago

Thank you