search

michaelklishin / cassandra-chef-cookbook

Chef cookbook for Apache Cassandra, DataStax Enterprise (DSE) and DataStax agent
Apache License 2.0
163 stars 228 forks source link

[breaking] Sync cassandra-env.sh and jvm.options with Cassandra 3 #328

Closed wdauchy closed 7 years ago

wdauchy commented 7 years ago

tested on both cassandra 2.1.x and 3.x

michaelklishin commented 7 years ago

Noted. Since the title says it includes breaking changes (and yes, some defaults indeed change), let's wait for 4.3.0 before merging this.

michaelklishin commented 7 years ago

@wdauchy @jfwm2 speaking of 4.3.0, I can release it as soon as you folks confirm that master is in good enough shape for you to run it in production ;)

wdauchy commented 7 years ago

@michaelklishin this commit is in production on our side for a few months now (september). so in my opinion it is ok.

I however could not find a solution to fix tests; might need new eyes... any hint?

michaelklishin commented 7 years ago

@wdauchy I understand that but there is no shortage of other changes in master. They may or may not be in your deployed fork: I cannot know that and thus clarifying.

michaelklishin commented 7 years ago

I will take a look at the tests. chef-spec doesn't produce diffs so it has to be done by hand :(

wdauchy commented 7 years ago

@michaelklishin yup hard to cover all possible configurations; a merge several times before an official release will probably facilitate tests for people

wdauchy commented 7 years ago

@michaelklishin we are now good on tests side

michaelklishin commented 7 years ago

@wdauchy ack. I will proceed with the 4.3.0 release then.

michaelklishin commented 7 years ago

4.3.0 is out, let's wait for a few days and unless there's urgent need to do a point release, merge this.

wdauchy commented 7 years ago

agreed :+1:

michaelklishin commented 7 years ago

Thank you!