michaelpapworth / tinymce-knockout-binding

A KnockoutJS custom binding that applies a TinyMCE Editor to the bound HTML element
MIT License
39 stars 19 forks source link

Package Dependencies #9

Open mdurling opened 10 years ago

mdurling commented 10 years ago

It is my understanding that most applications will use either TinyMCE -or- TinyMCE.jQuery, but not both. This package creates a dependency on both packages. Installing this package requires the user to install both versions of TinyMCE and to do so in the correct order since they will overwrite each other. Perhaps a separate tinymce-jquery-knockout-binding is required.

michaelpapworth commented 10 years ago

Can I direct you here?

This basically sums up why this design decision was made. Hope it helps.

mdurling commented 10 years ago

Thanks for the link. I am still confused though. In version 4.0, both tinymce and tinymce.jquery packages largely contain the same files (although the content of those files is different. Installing the second version overwrites the first version so it does not make sense to install both. However, if I want to install your knockout binding then I am forced to install both tinymce packages and I must be careful in doing so. It would be nice if you could specify an either/or dependency, but I don't believe nuget allows that. I can make this work, however, it seems confusing. Since I already use jquery, I only really need tinymce.jquery, but I must first install tinymce, overwrite those files by installing tinymce.jquery, and then install your binding. I don't blame you for not wanting to maintain two different packages when your code is probably the same in either scenario.

Michael 919.201.5562

On Tue, Jun 3, 2014 at 3:37 AM, Michael Papworth notifications@github.com wrote:

Can I direct you here http://stackoverflow.com/questions/21434388/how-do-i-use-tinymce-jquery-package-and-what-is-the-difference-with-tinymce-jque ?

This basically sums up why this design decision was made. Hope it helps.

— Reply to this email directly or view it on GitHub https://github.com/michaelpapworth/tinymce-knockout-binding/issues/9#issuecomment-44928619 .

michaelpapworth commented 10 years ago

My apologies, I think I misunderstood your question. Having investigated, there is actually no requirement for a NuGet dependency on TinyMCE since TinyMCE.JQuery provides everything we need. In my opinion (yet contrary to my initial belief) TinyMCE.JQuery should only contain the jQuery plugin and in turn take the dependency on TinyMCE. I'll get my package and documentation updated a.s.a.p.

Sorry about the confusion and thanks again for bringing this to my attention.

oising commented 9 years ago

Came here to log the same issue -- having dependencies on both packages doesn't make any sense. This should not be an enhancement: It is a bug.

rogersillito commented 7 years ago

This caused me some headscratching... I had simply installed the tinymce-knockout-binding nuget package (but unfortunately said "no to all" at the point where the tinymce.jquery package wanted to replace the files previously installed by the tinymce package). This resulted in the editor box appearing with style visibility="hidden" - and basically tinyMCE not working at all.

Until this is tidied up, then: