search

michaelrsweet / pdfio

PDFio is a simple C library for reading and writing PDF files.
https://www.msweet.org/pdfio
Apache License 2.0
199 stars 44 forks source link

small tweaks to Makefile.in #55

Closed eli-schwartz closed 12 months ago

eli-schwartz commented 12 months ago

Mostly, if --mandir is specified it used to be ignored in favor of ${datadir}/man.

michaelrsweet commented 12 months ago

[master 8628175] Fix man page installation to use mandir (Issue #55)

eli-schwartz commented 12 months ago

[master 8628175] Fix man page installation to use mandir (Issue #55)

FWIW I specifically submitted this as two separate commits so that using git cherry-pick would be trivial to do if needed. If fetching the changes through GitHub is confusing, I've discovered a really neat trick you can do with GitHub to fetch a PR using git itself: https://git.sr.ht/~eschwartz/dotfiles/tree/master/item/.bash_aliases#L6:

alias git-pr-setup="git config --local --add remote.origin.fetch '+refs/pull/*/head:refs/pull/*'"

This adds a git fetch refspec which allows you to checkout or git log a PR as refs/pull/XXX.

I would also have been quite happy to apply your requested changes. :)

eli-schwartz commented 12 months ago

WRT running config.status when the .in files are changed, I'm not keen on that because it can cause side-effects (not having the same environment, and less commonly running config.status twice can cause problems) that have tripped me up in the past...

I'd also like to add that I've never seen this happen. It is not supposed to be possible. The config.status Makefile is run as a kind of fancy sed at the end of configure, and only replaces "precious" substitutions.

Running ./configure automatically is risky because while config.status --recheck will attempt to preserve all precious environment variables between automatic reconfigures, there's no guarantee that the configure.ac's custom code marks every possible environment variable used as "autoconf precious variables", so it can't reliably reproduce the same environment.

Since AC_CONFIG_FILES doesn't run arbitrary user code, it doesn't have the same issue. Every allowable substitution is tracked by configure and written into config.status, rerunning it will just re-run the instantiated substitutions.

michaelrsweet commented 12 months ago

It is certainly possible that the bugs have been worked out - I was dealing with those issues 25+ years ago - but regardless I don't want to auto-update generated files.