search

michaelrsweet / pdfio

PDFio is a simple C library for reading and writing PDF files.
https://www.msweet.org/pdfio
Apache License 2.0
199 stars 44 forks source link

fix misspelled variable: PKCONFIG #56

Closed eli-schwartz closed 11 months ago

eli-schwartz commented 11 months ago

This prevented using pkg-config for zlib lookup.

As noted elsewhere, using pkg.m4's PKG_CHECK_MODULES would handle quite a bit of this for you...

eli-schwartz commented 11 months ago

Not sure what version of autoconf you're using but it looks right.

I'm using the one on Gentoo. It appears to have a couple of backported fixes from autoconf in git master, in particular: https://git.savannah.gnu.org/cgit/autoconf.git/commit/?id=8b5e2016c7ed2d67f31b03a3d2e361858ff5299b https://git.savannah.gnu.org/cgit/autoconf.git/commit/?id=bf5a75953b6d504f0405b1ca33b039b8dd39eef4

Which is needed to avoid autoconf erroring out or giving incorrect results with the upcoming GCC 14 / clang 17 (which drop support for K&R C constructs that were removed from the c99 standard).