search

michaeltyson / TPKeyboardAvoiding

A drop-in universal solution for moving text fields out of the way of the keyboard in iOS
http://atastypixel.com/blog/a-drop-in-universal-solution-for-moving-text-fields-out-of-the-way-of-the-keyboard/
zlib License
5.81k stars 925 forks source link

Can't build architectures for versions pre iOS 12 with Carthage #296

Open CochiorasBogdan opened 3 years ago

CochiorasBogdan commented 3 years ago

The IPHONEOS_DEPLOYMENT_TARGET was raised to iOS 12 in latest version 1.3.5 https://github.com/michaeltyson/TPKeyboardAvoiding/commit/ef7a25b3002f94667eedcf804dcc994109caf126 and anyone supporting pre iOS 12 cannot build the framework since Carthage only builds architectures available for the configured deployment target and above. Can this be lowered back to at least iOS 10? I saw it was iOS 8 before. In my opinion this should be in sync with the podspec platform which is iOS 9 currently (s.platform = :ios, '9.0'). In case it matters I am supporting iOS 10 and cannot build arhitectures for it like armv7.

Alrassas commented 3 years ago

@CochiorasBogdan, any updates regarding your question? or did you find a workaround to solve that?

CochiorasBogdan commented 3 years ago

@CochiorasBogdan, any updates regarding your question? or did you find a workaround to solve that?

I downgraded to 1.3.4, but for other Third party SDKs I changed the deployment target to the version I supported (iOS 10) recompiled the SDK to XCFramework and the issue was resolved. Not sure if this SDK supports lower deployment target but I presume it does if for CocoaPods minimum is iOS 9. Carthage only compiles architectures available for the specified deploy target here is a similar issue: https://github.com/Carthage/Carthage/issues/2297