search

michaelwittig / node-i18n-iso-countries

i18n for ISO 3166-1 country codes
MIT License
815 stars 262 forks source link

Wrong Official Name of South Korea and North Korea #324

Open yukha-dw opened 1 year ago

yukha-dw commented 1 year ago

Hello, I just checked ISO website and found out the defined official name of South Korea and North Korea on this module is different with theirs. Meanwhile, Iran is same.

This ISO (Short) ISO (Full) ISO (Link)
South Korea Korea (the Republic of) the Republic of Korea https://www.iso.org/obp/ui/#iso:code:3166:KR
North Korea Korea (the Democratic People's Republic of) the Democratic People's Republic of Korea https://www.iso.org/obp/ui/#iso:code:3166:KP
Islamic Republic of Iran Iran (Islamic Republic of) the Islamic Republic of Iran https://www.iso.org/obp/ui/#iso:code:3166:IR

Is it intentional to easily differentiate them? Thank you

michaelwittig commented 1 year ago

Hi @yukha-dw We usually stick with the official ISO name. In the case of North/South Korea the names are very confusing because they are almost identically. So we decided to go with North/South Korea first.

At least for South Korea, we also have aliases that include the official names, see #312

We also have an alias for Islamic Republic of Iran => Iran

yukha-dw commented 1 year ago

Hi @yukha-dw We usually stick with the official ISO name. In the case of North/South Korea the names are very confusing because they are almost identically. So we decided to go with North/South Korea first.

At least for South Korea, we also have aliases that include the official names, see #312

We also have an alias for Islamic Republic of Iran => Iran

I see, so "official" parameter doesn't guarantee to return official names but more like most common used name, right?

michaelwittig commented 1 year ago

As far as I remember the first entry should be the official name while the second entry is the alias aka most common used name. But I see that not all entries follow this order...