michal-josef-spacek / App-Schema-Deploy

Base class and script for Schema deploy.
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Possible precedence problem between ! and string eq #1

Open eserte opened 2 hours ago

eserte commented 2 hours ago

t/App-Schema-Deploy/04-run.t fails with perl 5.41.x (e.g. 5.41.4) like this:

#   Failed test 'no warnings'
#   at /opt/perl-5.41.4/lib/5.41.4/Test/Builder.pm line 193.
# There were 1 warning(s)
#     Previous test 0 ''
#     Possible precedence problem between ! and string eq at /opt/perl-5.41.4/lib/site_perl/5.41.4/SQL/Translator/Schema/Trigger.pm line 359.
#  at /opt/perl-5.41.4/lib/site_perl/5.41.4/SQL/Translator/Schema/Trigger.pm line 359.
#   require SQL/Translator/Schema/Trigger.pm called at /opt/perl-5.41.4/lib/site_perl/5.41.4/SQL/Translator/Schema.pm line 33
#   SQL::Translator::Schema::BEGIN() called at /opt/perl-5.41.4/lib/site_perl/5.41.4/SQL/Translator/Schema.pm line 33
#   eval {...} called at /opt/perl-5.41.4/lib/site_perl/5.41.4/SQL/Translator/Schema.pm line 33
#   require SQL/Translator/Schema.pm called at /opt/perl-5.41.4/lib/site_perl/5.41.4/SQL/Translator.pm line 20
#   SQL::Translator::BEGIN() called at /opt/perl-5.41.4/lib/site_perl/5.41.4/SQL/Translator.pm line 20
#   eval {...} called at /opt/perl-5.41.4/lib/site_perl/5.41.4/SQL/Translator.pm line 20
#   require SQL/Translator.pm called at (eval 81) line 1
#   eval 'require SQL::Translator;SQL::Translator->VERSION(0.11018);' called at /home/e/eserte/.cpan/build/2024092918/DBIx-Class-0.082843-1/blib/lib/DBIx/Class/Optional/Dependencies.pm line 704
#   DBIx::Class::Optional::Dependencies::_check_deps("DBIx::Class::Optional::Dependencies", "deploy") called at /home/e/eserte/.cpan/build/2024092918/DBIx-Class-0.082843-1/blib/lib/DBIx/Class/Optional/Dependencies.pm line 669
#   DBIx::Class::Optional::Dependencies::req_ok_for("DBIx::Class::Optional::Dependencies", "deploy") called at /home/e/eserte/.cpan/build/2024092918/DBIx-Class-0.082843-1/blib/lib/DBIx/Class/Storage/DBI.pm line 3228
#   DBIx::Class::Storage::DBI::deployment_statements(DBIx::Class::Storage::DBI::SQLite=HASH(0x56000e8cfce8), Schema::Foo::0_1_0=HASH(0x56000e4fd120), undef, undef, undef, HASH(0x56000f10c898)) called at /home/e/eserte/.cpan/build/2024092918/DBIx-Class-0.082843-1/blib/lib/DBIx/Class/Storage/DBI/SQLite.pm line 245
#   DBIx::Class::Storage::DBI::SQLite::deployment_statements(DBIx::Class::Storage::DBI::SQLite=HASH(0x56000e8cfce8), Schema::Foo::0_1_0=HASH(0x56000e4fd120), undef, undef, undef, HASH(0x56000f10c898)) called at /home/e/eserte/.cpan/build/2024092918/DBIx-Class-0.082843-1/blib/lib/DBIx/Class/Schema.pm line 1173
#   DBIx::Class::Schema::deployment_statements(Schema::Foo::0_1_0=HASH(0x56000e4fd120), undef, undef, undef, HASH(0x56000f10c898)) called at /home/e/eserte/.cpan/build/2024092918/DBIx-Class-0.082843-1/blib/lib/DBIx/Class/Storage/DBI.pm line 3277
#   DBIx::Class::Storage::DBI::deploy(DBIx::Class::Storage::DBI::SQLite=HASH(0x56000e8cfce8), Schema::Foo::0_1_0=HASH(0x56000e4fd120), undef, HASH(0x56000e83eb08), undef) called at /home/e/eserte/.cpan/build/2024092918/DBIx-Class-0.082843-1/blib/lib/DBIx/Class/Schema.pm line 1147
#   DBIx::Class::Schema::deploy(Schema::Foo::0_1_0=HASH(0x56000e4fd120), HASH(0x56000e83eb08)) called at /home/e/eserte/.cpan/build/2024092918/App-Schema-Deploy-0.05-1/blib/lib/App/Schema/Deploy.pm line 101
#   eval {...} called at /home/e/eserte/.cpan/build/2024092918/App-Schema-Deploy-0.05-1/blib/lib/App/Schema/Deploy.pm line 100
#   App::Schema::Deploy::run(App::Schema::Deploy=HASH(0x56000e5cf280)) called at t/App-Schema-Deploy/04-run.t line 26
# 
# Looks like you failed 1 test of 7.
t/App-Schema-Deploy/04-run.t ...... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/7 subtests 
michal-josef-spacek commented 2 hours ago

This is a new warning of Perl 5.41.4 and it will be in SQL::Translator, not in this module.