micnews / inviewport

Check if a dom element is fully contained in the viewport
5 stars 1 forks source link

in-viewport? #1

Open vvo opened 9 years ago

vvo commented 9 years ago

Hi I made https://github.com/vvo/in-viewport.

Have you seen it? considering using it? if not, why? (so I can make it better)

its the base building block of my lazyload script used on hundreds of websites serving million page views.

thanks @juliangruber

juliangruber commented 9 years ago

i don't remember the exact reasons, i think i discovered your module after i got the first version of this working. it didn't let you abort the watch mode and the implementation is a lot more complex.

any other thoughts, @micnews/owners?

vvo commented 9 years ago

Oh yeah there are a lot of cases I had to deal with + some libraries are inlined:

I agree this complexifies the library so it's all up to you. in-viewport was built as a solution to the https://github.com/vvo/lazyload library. This is part of an automatic web perfomance optimizer reverse proxy: http://www.fasterize.com/en

Being able to unwatch would be a good addition even if no one ever asked for it.

Everything is tested.

Thanks !