Closed turbomam closed 1 month ago
problematic example data files:
Actually, this seems unrelated to eluent_introduction_category
[ERROR] [src/data/problem/Database-mass-spectrometry.yaml/0] 'nmdc:dgms-99-zUCd5N' does not match '^(nmdc):(dgns|omprc)-([0-9][a-z]{0,6}[0-9])-([A-Za-z0-9]{1,})(\\.[A-Za-z0-9]{1,})*(_[A-Za-z0-9_\\.-]+)?$' in /data_generation_set/0/id [ERROR] [src/data/problem/Database-mass-spectrometry.yaml/0] 'nmdc:dgms-99-zUCd5x' does not match '^(nmdc):(dgns|omprc)-([0-9][a-z]{0,6}[0-9])-([A-Za-z0-9]{1,})(\\.[A-Za-z0-9]{1,})*(_[A-Za-z0-9_\\.-]+)?$' in /data_generation_set/1/id
nmdc:dgms-99-zUCd5N
and nmdc:dgms-99-zUCd5x
are both asserted to be of type nmdc:MassSpectrometry
MassSpectrometry is_a
DataGeneration and has
slot_usage:
id:
name: id
domain_of:
- NamedThing
structured_pattern:
syntax: '{id_nmdc_prefix}:(dgms|omprc)-{id_shoulder}-{id_blade}{id_version}{id_locus}'
interpolated: true
I added this to DataGeneration
slot_usage: id: pattern: "^nmdc:(omprc|dgms|dgns)-[0-9][a-z]{0,6}[0-9]-[A-Za-z0-9]{1,}(\\.[A-Za-z0-9]{1,})*(_[A-Za-z0-9_\\.-]+)?$" # better applied as a structured_pattern, but even that might get out of sync from the asserted Study structured_pattern
@brynnz22 @anastasiyaprymolenna @kheal
I did a back-merge from
nmdc-schema
intoberkeley-schema-fy24
this morning and accidentally pushed it intoberkeley-schema-fy24
main
instead of a branchEverything seems fine except for anything related to
eluent_introduction_category
Are we still going to use that after the remodeling @kheal did yesterday?
If so, I could use some help getting that to work again. I'll take responsibility for digging up the last good state of the two repos.
The eluent_introduction_category
is one of the slots I added during the remodel of the Chromatography Configurations, so yes we'll use that slot. Looks like you figured it out re:IDs, but let me know if I can help debug.
@brynnz22 @anastasiyaprymolenna @kheal
I did a back-merge from
nmdc-schema
intoberkeley-schema-fy24
this morning and accidentally pushed it intoberkeley-schema-fy24
main
instead of a branchEverything seems fine except for anything related to
eluent_introduction_category
Are we still going to use that after the remodeling @kheal did yesterday?
If so, I could use some help getting that to work again. I'll take responsibility for digging up the last good state of the two repos.