microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
26 stars 8 forks source link

`eluent_introduction_category` modeling broken in latest backmerge #1972

Closed turbomam closed 1 month ago

turbomam commented 1 month ago

@brynnz22 @anastasiyaprymolenna @kheal

I did a back-merge from nmdc-schema into berkeley-schema-fy24 this morning and accidentally pushed it into berkeley-schema-fy24 main instead of a branch

Everything seems fine except for anything related to eluent_introduction_category

Are we still going to use that after the remodeling @kheal did yesterday?

If so, I could use some help getting that to work again. I'll take responsibility for digging up the last good state of the two repos.

turbomam commented 1 month ago

problematic example data files:

turbomam commented 1 month ago

Actually, this seems unrelated to eluent_introduction_category

[ERROR] [src/data/problem/Database-mass-spectrometry.yaml/0] 'nmdc:dgms-99-zUCd5N' does not match '^(nmdc):(dgns|omprc)-([0-9][a-z]{0,6}[0-9])-([A-Za-z0-9]{1,})(\\.[A-Za-z0-9]{1,})*(_[A-Za-z0-9_\\.-]+)?$' in /data_generation_set/0/id
[ERROR] [src/data/problem/Database-mass-spectrometry.yaml/0] 'nmdc:dgms-99-zUCd5x' does not match '^(nmdc):(dgns|omprc)-([0-9][a-z]{0,6}[0-9])-([A-Za-z0-9]{1,})(\\.[A-Za-z0-9]{1,})*(_[A-Za-z0-9_\\.-]+)?$' in /data_generation_set/1/id
turbomam commented 1 month ago

nmdc:dgms-99-zUCd5N and nmdc:dgms-99-zUCd5x are both asserted to be of type nmdc:MassSpectrometry

MassSpectrometry is_a DataGeneration and has

slot_usage:
  id:
    name: id
    domain_of:
    - NamedThing
    structured_pattern:
      syntax: '{id_nmdc_prefix}:(dgms|omprc)-{id_shoulder}-{id_blade}{id_version}{id_locus}'
      interpolated: true
turbomam commented 1 month ago

I added this to DataGeneration

    slot_usage:
      id:
        pattern: "^nmdc:(omprc|dgms|dgns)-[0-9][a-z]{0,6}[0-9]-[A-Za-z0-9]{1,}(\\.[A-Za-z0-9]{1,})*(_[A-Za-z0-9_\\.-]+)?$" # better applied as a structured_pattern, but even that might get out of sync from the asserted Study structured_pattern
kheal commented 1 month ago

@brynnz22 @anastasiyaprymolenna @kheal

I did a back-merge from nmdc-schema into berkeley-schema-fy24 this morning and accidentally pushed it into berkeley-schema-fy24 main instead of a branch

Everything seems fine except for anything related to eluent_introduction_category

Are we still going to use that after the remodeling @kheal did yesterday?

If so, I could use some help getting that to work again. I'll take responsibility for digging up the last good state of the two repos.

The eluent_introduction_category is one of the slots I added during the remodel of the Chromatography Configurations, so yes we'll use that slot. Looks like you figured it out re:IDs, but let me know if I can help debug.