search

microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
27 stars 8 forks source link

RNA Plate position validation error #865

Closed mslarae13 closed 1 year ago

mslarae13 commented 1 year ago

A10 should validate for RNA plate position but it doesn't. It looks like it should based on the regular expression?

See https://data.microbiomedata.org/submission/3f6d765d-18e2-4fb4-8209-456a3b9d1a86/samples

DNA late position may also be wrong, I haven't checked it. Screen Shot 2023-04-13 at 5 28 46 PM

mslarae13 commented 1 year ago

@turbomam made changes to NMDC and submission schema and sample data to address this. The rules in NMDC schema are good, submission schema can import these rules. Mark will check this in an example data file.

DH doesn't understand rules. So nothing to connect that.

pkalita-lbl commented 1 year ago

Issue for implementing LinkML rules in DataHarmonizer: https://github.com/cidgoh/DataHarmonizer/issues/370

turbomam commented 1 year ago

The tube/plate/well rules work in terms of LinkML validation in both the nmdc-schema and the submission schema. The well/plate position columns are magenta/optional in the DataHarmonizer interface now.