search

microcks / microcks-testcontainers-java

Java lib for Testcontainers that enables embedding Microcks into your JUnit tests with lightweight, throwaway instance thanks to containers.
https://microcks.io
Apache License 2.0
18 stars 3 forks source link

Feedback on importArtifact #14

Closed eddumelendez closed 8 months ago

eddumelendez commented 9 months ago

Reason/Context

This is for the simplicity of the module, help maintenance and build on top of existing features.

Description

Looking at the code I found the importArtifact method and I was wondering if the docker image already provides the microcks cli and if would be much better to rely on withCopyFileToContainer from Testcontainers than implementing the http upload.

Didn't realize before but I think the same can be applied to testEndpoint, right?

Implementation ideas

No implementation is needed. Test describing the scenario and docs would be helpful. If that make sense then the importArtifact could be removed.

github-actions[bot] commented 9 months ago

👋 @eddumelendez

Welcome to the Microcks community! 💖

Thanks and congrats 🎉 for opening your first issue here! Be sure to follow the issue template or please update it accordingly.

📢 If you're using Microcks in your organization, please add your company name to this list. 🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact.

If you need to know why and how to add yourself to the list, please read the blog post "Join the Microcks Adopters list and Empower the vibrant open source Community 🙌"

Hope you have a great time there!

🌟 ~~~~~ 🌟

📢 If you like Microcks, please ⭐ star ⭐ our repo to support it!

🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact.

lbroudoux commented 9 months ago

Hi Eddu,

Thanks for the review and suggestion. The image does not contain the cli as we want to keep it as light as possible... Also the cli is under refactoring at the moment + I don't think it would ever be as stable as the raw APIs.