Open fw190 opened 7 years ago
So, should we submit Daniele's patch as a pull request to CM? Should we wait for him to do that?
I don't know - I'm just a regular user whos GPS stopped working and trying to find a solution.
After receiving permission to do so by Daniele, I opened a pull request (here).
I could not find precise instructions on how to contribute to CM, so I just opened a PR here on github, but I'm really not sure it's the right way.
As I thought, CM contributions must go through gerrit. I'll look into it but I never used it so it might take a while
Related note: I had opened a ticket in Jira only to find out that the "proper" place for raising discussion for something like this is in the forum.
...though I think a request in Gerrit is better anyway.
It seems the pull request was not accepted. We will need a way to install the app to /system, like flashable zip.
If you want, you can try my microG unofficial installer, it install all components (UnifiedNlp is included in GmsCore).
As an alternative you can use haystack and my non-official patch: https://github.com/Lanchon/haystack/issues/3#issuecomment-275887254
I just stumpled across the whole issue. Should we try to issue a new pull request, as cyanogenmod now is lineageos? And: Where is the patch? CM webpages are down
On February 25, 2017 7:07:20 AM MST, Paul notifications@github.com wrote:
I just stumpled across the whole issue. Should we try to issue a new pull request, as cyanogenmod now is lineageos?
The same people are working on LOS. This project needs to just provide a flashable zip. Y
I suspect I can help with this problem. Could it be related to Google's "plus code" address? Or perhaps the ISO 8601 standard that is currently under revision?
@evanstapler: What do you mean?
This problem is just an intentional limitation put by Android developers.
A suggested here when you use Cyanogenmod 14.1 UnifiedNlp doesn't work - the only solution is to pull the patch by Cyanogenmod developers.