search

micrometer-metrics / micrometer

An application observability facade for the most popular observability tools. Think SLF4J, but for observability.
https://micrometer.io
Apache License 2.0
4.48k stars 991 forks source link

micrometer cloudwatch should publish StatisticSet when any aggregations are done client side. #1784

Open ghost opened 4 years ago

ghost commented 4 years ago

Micrometer cloudwatch current publishes separate metrics for a Timer under different prefixes (avg, count, sum, max). Since Cloudwatch also does statistical aggregations this makes the client side aggregations a deterrent to being able to use the full capabilities of cloudwatch. Aggregation in itself is not a bad thing, but it needs to be sent to cloudwatch as an aggregation via a StatisticSet.

shakuzen commented 4 years ago

Thank you for bringing this to our attention. Would you be willing to contribute a pull request for this?

ghost commented 4 years ago

Hey Tommy,

Yeah I am actually getting one together. I'd love to contribute!

On Mon, Jan 13, 2020, 11:37 AM Tommy Ludwig notifications@github.com wrote:

Thank you for bringing this to our attention. Would you be willing to contribute a pull request for this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/micrometer-metrics/micrometer/issues/1784?email_source=notifications&email_token=ABMVYEB7AHEJOPSFS6BJKBDQ5SKF3A5CNFSM4KFIKYB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIZMX4Q#issuecomment-573754354, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMVYEAVNK2IKRBVIBSPOXLQ5SKF3ANCNFSM4KFIKYBQ .

thrxde commented 4 years ago

To implement this feature, it is necessary to provide an "min" value in micrometer. see: min statistic for distribution summaries and timers #457