microsoft / ADBench

Benchmarking various AD tools.
MIT License
107 stars 40 forks source link

Repairing PyTorch Hand objective differentiation #135

Closed mikhailnikolaev closed 5 years ago

mikhailnikolaev commented 5 years ago

Fixings that are applied due to issue #112

Additional changes:

  1. Hand test data flattening for Python
  2. Decreasing tolerance for PyTorch to 1e-7 because precision 1e-8 is too small for Hand objective differentiation in complicated case for some sets of input data
  3. Some code fixings and refactoring

Graphs

HAND (Complicated, Small)  Jacobian  - Release Graph HAND (Simple, Big)  Jacobian  - Release Graph HAND (Simple, Small)  Jacobian  - Release Graph HAND (Complicated, Big)  Jacobian  - Release Graph
mikhailnikolaev commented 5 years ago

That looks great! The code became simpler 👍

Thanks!