Closed v-xianya closed 1 month ago
@v-xianya Thank you for finding this! I've been hardening our publish storage account with Azure Front Door, and it looks like I missed updating a forward link. That's been fixed now. Please try again.
Related to #8143
Hi @craxal Verified this issue on the rel build 20240926.1. Fixed on Linux. We also tested it on MacOS arm64 and Windows x64&arm64 platforms. This issue reproduces on MacOS arm64 and Windows arm64.
@v-xianya So, the download URL in the versions file was pointing directly to our publish container, for which I've disabled anonymous blob access, so I can easily see why Windows ARM isn't working. I just need to update the versions file.
macOS ARM, though...that's a bit concerning. I've updated the version file, so can you verify whether this continues to reproduce for macOS ARM?
Hi @craxal Verified this issue on the rel build 20240926.1. Fixed on MacOS ARM. Still no notification prompts on Windows arm64.
@v-xianya Oh, I think that's because I had caching enabled on the CDN. I updated the version2.json file, but no matter how many times I was refreshing in the browser, it wasn't updating. After disabling caching, I started getting the updated versino2.json. Try it one more time.
Hi @craxal Verified this issue on build 20240929.1. Here are the behaviors: When opening Storage Explorer with the command --add-update-group=CTI.
For MacOS ARM and Linux, below update notification prompts when launching Storage Explorer normally (Without the command --add-update-group=CTI ). This issue doesn't occur for Windows arm64 and x64.
The message tells me that you are at least getting the right version info. I'll continue investigating.
I was not able to reproduce when running macOS ARM with the command --add-update-group=CTI
:
I've made a few observations:
--add-update-group=CTI
option is not provided every time after.In light of these observations, I have a few follow-up questions:
--add-update-group=CTI
option, whether you see the update message or not), check whether the CTI group is applied:
Standalone_RolloutPercentile_v1
. Is there a CTI: {name: "CTI", percentage: 100}
value?@MRayermannMSFT found that the issue was related to a change in platform behavior such that certain platform detection functions were returning incorrect responses. Logic was restructured slightly to account for this, so Windows ARM should now be getting updates.
@craxal Verified this issue on the rel build 20241011.2. On Windows ARM64, run command: .\StorageExplorer.exe --add-update-group=CTI below update prompts. On Windows x64, below update prompts after installing and opening storage explorer. On MacOS ARM, below update prompts regardless of the option '--add-update-group=CTI' is provided. On Linux, below update prompts when running ./StorageExplorer --add-update-group=CTI to open storage explorer.
@v-xianya once you run --add-update-group
, that group is saved, even if you restart Storage Explorer. Can you try using --remove-update-group=CTI
, and verify that after running that, that the update notification goes away?
@v-xianya What you are now observing appears to be expected behavior, but we're not 100% sure about your latest findings, whether they're expected behaviors and what steps were followed.
We all followed the test case instructions and were able to verify update notifications appeared as expected for all platforms. As mentioned before, the --add-update-group
option persists between sessions, whether it's included or not. You need to use --remove-update-group
, otherwise you will continue to get update notifications.
In the future, can you be sure to be explicit about new or alternate steps taken and expected/observed results? We need to make sure we minimize ambiguities in ongoing discussions such as this.
In the future, can you be sure to be explicit about new or alternate steps taken and expected/observed results?
Ok, got it, we will do.
Storage Explorer Version: 1.36.0 (101) Build Number: 20240925.3 Branch: rel/1.36.0 Platform/OS: Linux Ubuntu 22.04 Architecture: x64 How Found: From running test cases Regression From: Previous release (1.35.0)
Steps to Reproduce
Expected Experience
The update notification appears.
Actual Experience
No update notification appears.
Additional Context