microsoft / AzureStorageExplorer

Easily manage the contents of your storage account with Azure Storage Explorer. Upload, download, and manage blobs, files, queues, tables, and Cosmos DB entities. Gain easy access to manage your virtual machine disks. Work with either Azure Resource Manager or classic storage accounts, plus manage and configure cross-origin resource sharing (CORS) rules.
Creative Commons Attribution 4.0 International
378 stars 87 forks source link

No update notification appears when running './StorageExplorer --add-update-group=CTI' to open Storage Explorer on Linux #8202

Closed v-xianya closed 1 month ago

v-xianya commented 2 months ago

Storage Explorer Version: 1.36.0 (101) Build Number: 20240925.3 Branch: rel/1.36.0 Platform/OS: Linux Ubuntu 22.04 Architecture: x64 How Found: From running test cases Regression From: Previous release (1.35.0)

Steps to Reproduce

  1. Download StorageExplorer-linux.tar.gz on Linux -> Extract it.
  2. Open terminal, navigate to the folder's location, run "./StorageExplorer --add-update-group=CTI".
  3. Storage Explorer opens.
  4. Check whether the update notification appears.

Expected Experience

The update notification appears. image

Actual Experience

No update notification appears.

Additional Context

  1. This issue doesn't reproduce for Windows.
  2. No mac arm64 signed build. so we haven't test this case on MacOS.
craxal commented 2 months ago

@v-xianya Thank you for finding this! I've been hardening our publish storage account with Azure Front Door, and it looks like I missed updating a forward link. That's been fixed now. Please try again.

Related to #8143

v-xianya commented 2 months ago

Hi @craxal Verified this issue on the rel build 20240926.1. Fixed on Linux. We also tested it on MacOS arm64 and Windows x64&arm64 platforms. This issue reproduces on MacOS arm64 and Windows arm64.

craxal commented 2 months ago

@v-xianya So, the download URL in the versions file was pointing directly to our publish container, for which I've disabled anonymous blob access, so I can easily see why Windows ARM isn't working. I just need to update the versions file.

macOS ARM, though...that's a bit concerning. I've updated the version file, so can you verify whether this continues to reproduce for macOS ARM?

v-xianya commented 2 months ago

Hi @craxal Verified this issue on the rel build 20240926.1. Fixed on MacOS ARM. Still no notification prompts on Windows arm64.

craxal commented 2 months ago

@v-xianya Oh, I think that's because I had caching enabled on the CDN. I updated the version2.json file, but no matter how many times I was refreshing in the browser, it wasn't updating. After disabling caching, I started getting the updated versino2.json. Try it one more time.

v-xianya commented 2 months ago

Hi @craxal Verified this issue on build 20240929.1. Here are the behaviors: When opening Storage Explorer with the command --add-update-group=CTI.

  1. No update notification for Windows arm64/MacOS ARM/Linux.
  2. Below update notification prompts for Windows x64. image

For MacOS ARM and Linux, below update notification prompts when launching Storage Explorer normally (Without the command --add-update-group=CTI ). This issue doesn't occur for Windows arm64 and x64. image

craxal commented 1 month ago

The message tells me that you are at least getting the right version info. I'll continue investigating.

craxal commented 1 month ago

I was not able to reproduce when running macOS ARM with the command --add-update-group=CTI:

image

I've made a few observations:

In light of these observations, I have a few follow-up questions:

craxal commented 1 month ago

@MRayermannMSFT found that the issue was related to a change in platform behavior such that certain platform detection functions were returning incorrect responses. Logic was restructured slightly to account for this, so Windows ARM should now be getting updates.

v-xianya commented 1 month ago

@craxal Verified this issue on the rel build 20241011.2. On Windows ARM64, run command: .\StorageExplorer.exe --add-update-group=CTI below update prompts. Image On Windows x64, below update prompts after installing and opening storage explorer. Image On MacOS ARM, below update prompts regardless of the option '--add-update-group=CTI' is provided. Image On Linux, below update prompts when running ./StorageExplorer --add-update-group=CTI to open storage explorer. Image

MRayermannMSFT commented 1 month ago

@v-xianya once you run --add-update-group, that group is saved, even if you restart Storage Explorer. Can you try using --remove-update-group=CTI, and verify that after running that, that the update notification goes away?

craxal commented 1 month ago

@v-xianya What you are now observing appears to be expected behavior, but we're not 100% sure about your latest findings, whether they're expected behaviors and what steps were followed.

We all followed the test case instructions and were able to verify update notifications appeared as expected for all platforms. As mentioned before, the --add-update-group option persists between sessions, whether it's included or not. You need to use --remove-update-group, otherwise you will continue to get update notifications.

In the future, can you be sure to be explicit about new or alternate steps taken and expected/observed results? We need to make sure we minimize ambiguities in ongoing discussions such as this.

v-xianya commented 1 month ago

In the future, can you be sure to be explicit about new or alternate steps taken and expected/observed results? Ok, got it, we will do.