microsoft / AzureTRE

An accelerator to help organizations build Trusted Research Environments on Azure.
https://microsoft.github.io/AzureTRE
MIT License
185 stars 145 forks source link

Open AI Workspace Service #4075

Closed harryy94 closed 2 months ago

harryy94 commented 3 months ago

Addition of Open AI Workspace Service for #3810

This builds upon @marrobi 's original draft PR.

We are able to install an Open AI service and access it via the VM, and are still in progress of doing more tests, but welcome any feedback in the meantime!

github-actions[bot] commented 3 months ago

Unit Test Results

0 tests   0 :white_check_mark:  0s :stopwatch: 0 suites  0 :zzz: 0 files    0 :x:

Results for commit 3669487c.

:recycle: This comment has been updated with latest results.

marrobi commented 3 months ago

Works great for me, once I sorted quota issues out. I had to manually set the version, as the default "auto update" selection didn;t work, seemed to be trying to use a version not available in the region.

image

Blocked external:

image

Works internal: image

We should surface the API key somehow as a later issue as per #2401

Thanks!

marrobi commented 3 months ago

@harryy94 can you add the tags, not sure what was wrong before, but should support them: image

harryy94 commented 2 months ago

@harryy94 can you add the tags, not sure what was wrong before, but should support them: image

Hi, thanks for your review :) For the above I realised I forgot this line

tags                          = local.workspace_service_tags

so I've added that in on the OpenAI instance. The other error I was getting was I accidentally tried to add tags on the deployment instead of the instance which doesn't support tags.

marrobi commented 2 months ago

/test-extended 3669487

Given base workspace and core changes doing full test.

github-actions[bot] commented 2 months ago

:robot: pr-bot :robot:

:runner: Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/10665019851 (with refid cc34db55)

(in response to this comment from @marrobi)

marrobi commented 2 months ago

/destroy-test-env

github-actions[bot] commented 2 months ago

:robot: pr-bot :robot:

/destroy-test-env is not recognised as a valid command.

You can use the following commands:     /test - build, deploy and run smoke tests on a PR     /test-extended - build, deploy and run smoke & extended tests on a PR     /test-extended-aad - build, deploy and run smoke & extended AAD tests on a PR     /test-shared-services - test the deployment of shared services on a PR build     /test-force-approve - force approval of the PR tests (i.e. skip the deployment checks)     /test-destroy-env - delete the validation environment for a PR (e.g. to enable testing a deployment from a clean start after previous tests)     /help - show this help

(in response to this comment from @marrobi)

marrobi commented 2 months ago

/test-destroy-env

github-actions[bot] commented 2 months ago

Destroying PR test environment (RG: rg-trecc34db55)... (run: https://github.com/microsoft/AzureTRE/actions/runs/10668007159)

github-actions[bot] commented 2 months ago

PR test environment destroy complete (RG: rg-trecc34db55)

tim-allen-ck commented 2 months ago

I seem to keep hitting this error:

 Error: Failed to download module
│ 
│ Could not download module "terraform_azurerm_environment_configuration" (main.tf:30) source code from
│ "git::https://github.com/microsoft/terraform-azurerm-environment-configuration.git?ref=0.6.0": error downloading
│ 'https://github.com/microsoft/terraform-azurerm-environment-configuration.git?ref=0.6.0': /usr/local/bin/git exited with 128: fatal: detected
│ dubious ownership in repository at
│ '/workspaces/AzureTRE/templates/workspace_services/openai/terraform/.terraform/modules/terraform_azurerm_environment_configuration'
│ To add an exception for this directory, call:
│ 
│       git config --global --add safe.directory
│ /workspaces/AzureTRE/templates/workspace_services/openai/terraform/.terraform/modules/terraform_azurerm_environment_configuration
│ 

Any ideas to add it permanently in?

marrobi commented 2 months ago
detected
│ dubious ownership in repository at

This in the dev container when building? I didn't get that. Weird.

That module is used by other bundles too, so weird just seeing it now.

tim-allen-ck commented 2 months ago
detected
│ dubious ownership in repository at

This in the dev container when building? I didn't get that. Weird.

That module is used by other bundles too, so weird just seeing it now.

Yeah I figured it was used elsewhere. Yes, doing a container deploy I ended up doing it multiple times for different bundles in the end.