search

microsoft / AzureTRE

An accelerator to help organizations build Trusted Research Environments on Azure.
https://microsoft.github.io/AzureTRE
MIT License
185 stars 145 forks source link

Update KeyVault references #4112

Closed marrobi closed 2 weeks ago

marrobi commented 1 month ago

Fixes #4110 #2463

This pull request updates the references to KeyVault secrets in the code. The AAD_TENANT_ID, API_CLIENT_ID, and API_CLIENT_SECRET references are now constructed using the version so terraform cascades the update.

github-actions[bot] commented 1 month ago

Unit Test Results

0 tests   0 ✅  0s ⏱️ 0 suites  0 💤 0 files    0 ❌

Results for commit 5011793d.

:recycle: This comment has been updated with latest results.

marrobi commented 1 month ago

/test-extended

github-actions[bot] commented 1 month ago

:robot: pr-bot :robot:

:runner: Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/11498586135 (with refid 9655aa5d)

(in response to this comment from @marrobi)

tamirkamara commented 2 weeks ago

What does it mean that it cascades the update?

marrobi commented 2 weeks ago

now constructed using the version so terraform cascades the update.

So that it updates the API app configuration values when the key vault secret version is updates. It seems that terraform doesn't always update the reference.

As per issue discussion see - https://github.com/hashicorp/terraform-provider-azurerm/issues/3129#issuecomment-766273903

yuvalyaron commented 2 weeks ago

/test-extended

github-actions[bot] commented 2 weeks ago

:robot: pr-bot :robot:

:runner: Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/11704066429 (with refid 9655aa5d)

(in response to this comment from @yuvalyaron)

marrobi commented 2 weeks ago

/test-extended

github-actions[bot] commented 2 weeks ago

:robot: pr-bot :robot:

:runner: Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/11708350316 (with refid 9655aa5d)

(in response to this comment from @marrobi)