search

microsoft / BotFramework-DirectLine-DotNet

C# client library for Microsoft Bot Framework's Direct Line protocol
MIT License
27 stars 36 forks source link

Quick Fix for the Sample Availability #12

Closed junczhu closed 6 months ago

junczhu commented 3 years ago

image

By doing quick test I found in line 83 the value of x.From.Id will be either DirectLineSampleClientUser or directline=csharp

And in this case we need set value to directline-csharp of an expected output.

BR, CharingJC

ghost commented 3 years ago

CLA assistant check
All CLA requirements met.

junczhu commented 3 years ago

Hello @CharingJC

The botId should be coming from app.config: https://github.com/microsoft/BotFramework-DirectLine-DotNet/blob/main/samples/core-DirectLineWebSockets/DirectLineClient/App.config#L5

Maybe the Readme.md should state this. Would you care to update these two readmes, instructing users to add their bot's id to the app.config?

Sure

junczhu commented 6 months ago

closed for long running PR