microsoft / BotFramework-Emulator

A desktop application that allows users to locally test and debug chat bots built with the Bot Framework SDK.
https://aka.ms/botemulator
MIT License
1.81k stars 753 forks source link

Getting security prompt to Open URL in latest version #1851

Closed BeMor81 closed 5 years ago

BeMor81 commented 5 years ago

Getting security prompt to Open URL in latest version which is preventing the OAuth2 Github example from working. Select Confirm on the prompt and nothing further happens.

mdrichardson commented 5 years ago

@BeMor81

  1. Can you provide the code that you use to display the OAuth Prompt?
  2. Did you follow the Authentication docs to get your App Registration set up with OAuth? Pay special attention to this section

The Open URL prompt is normal and just ensures that the bot isn't trying to open anything malicious.

I just connected through GitHub OAuth using the Bot Auth Sample and it worked just fine in Emulator. This is likely an issue with how you have Auth set up within your bot.

image

BeMor81 commented 5 years ago

@BeMor81

1. Can you provide the code that you use to display the OAuth Prompt?

2. Did you follow the [Authentication docs](https://docs.microsoft.com/en-us/azure/bot-service/bot-builder-authentication?view=azure-bot-service-4.0&tabs=csharp%2Cbot-oauth) to get your App Registration set up with OAuth? Pay special attention to [this section](https://docs.microsoft.com/en-us/azure/bot-service/bot-builder-authentication?view=azure-bot-service-4.0&tabs=csharp%2Cbot-oauth#create-and-register-an-azure-ad-application)

The Open URL prompt is normal and just ensures that the bot isn't trying to open anything malicious.

I just connected through GitHub OAuth using the Bot Auth Sample and it worked just fine in Emulator. This is likely an issue with how you have Auth set up within your bot.

image

Thanks for the reply. The authentication settings within the bot are configure and a test returns a token. I'm using the Bot example from github. I am using Azure AD v1 authentication though. I've uploaded my project to Azure and tested via the Direct Line javascript https://github.com/microsoft/BotFramework-DirectLineJS and all works fine

mdrichardson commented 5 years ago

I apologize. By "...which is preventing the OAuth2 Github", I took it as using GitHub OAuth, not AADv1.

However, I was still able to get this working with AADv1:

image

Here's a few things you can try:

Can you screenshot an image of it failing after you click Confirm? Does it present any errors or text in either Emulator or the console output?

mdrichardson commented 5 years ago

@BeMor81 Are you still experiencing this issue? It needs to stay active to stay open.

BeMor81 commented 5 years ago

Hi @mdrichardson, Thanks for following this up. I've reverted back to a previous version for now. I'll try the update again at a later date. Please feel free to close. Thanks for your time and help with this.

Edwardenis commented 5 years ago

@BeMor81 could you provide the version of the emulator that you used? I'm using emulator version 4.5.2 with AADv2 and is not working either

BeMor81 commented 5 years ago

@Edwardenis I'm using 4.3.0