microsoft / BotFramework-WebChat

A highly-customizable web-based client for Azure Bot Services.
https://www.botframework.com/
MIT License
1.6k stars 1.55k forks source link

Uploaded file in Polish appears to be empty #4403

Open compulim opened 2 years ago

compulim commented 2 years ago

Is it an issue related to Adaptive Cards?

Do you have any screenshots?

No response

What version of Web Chat are you using?

I am not using latest

Which distribution are you using Web Chat from?

Bundle (webchat.js)

Which hosting environment does this issue primarily affect?

Web apps

Which browsers and platforms do the issue happened?

Browser: Edge (latest), Browser: Chrome (latest), Browser: Firefox (latest), Browser: Safari (latest), Browser: IE Mode (latest), Platform: Windows, Platform: macOS, Platform: iOS/iPadOS, Platform: Android

Which area does this issue affect?

Attachment: Other rich cards

Is this an accessibility issue?

Please describe the bug

This issue repro as early as 4.8.0 (2020 March), and did not repro on 4.7.1 (2019 December).

The technical root cause is:

When the Unicode CLDR is downloaded from https://github.com/unicode-cldr/cldr-units-full/archive/36.0.0.zip, it does not contains one/few/many for short/digital-gigabyte, short/digital-megabyte, and short/digital-kilobyte.

image

However, the supplemental/plurals say Polish do have plural types of one/few/many, as shown below:

image

When we are doing our investigation, we also look at another source of Unicode CLDR, at https://github.com/unicode-org/cldr/blob/release-36/common/main/pl.xml. In this source, we do see short/digital-gigabyte et al. have one/few/many.

image

We concluded the issue is rooted from the Unicode CLDR v36 database. And it is causing globalize package to fail due to the missing strings.

Do you see any errors in console log?

Based on 4.14.1.

image

image

How to reproduce the issue?

  1. Use Polish and talk to MockBot
  2. Upload a file

What is the expected and actual behavior?

Expected: the uploaded file should display properly

Actual: the uploaded file appear to be an empty box

Adaptive Card JSON

No response

Additional context

IcM ticket 332820283 and 330190903.

compulim commented 2 years ago

Reopening after short-term fix. We should go for long-term fix.

compulim commented 2 years ago

This is filed as https://github.com/globalizejs/globalize/issues/932.