search

microsoft / Cognitive-Face-iOS

iOS SDK for the Microsoft Face API, part of Cognitive Services
https://www.microsoft.com/cognitive-services/en-us/face-api
Other
184 stars 64 forks source link

ListPersonsWithPersonGroupId not returning persisted Face Ids #21

Closed NateRickard closed 7 years ago

NateRickard commented 7 years ago

It appears that the API has changed since this SDK was last updated. SDK seems to be expecting faceIds to be returned in the JSON:

https://github.com/Microsoft/Cognitive-Face-iOS/blob/master/Pod/Classes/MPOPerson.m#L39

Whereas the API docs state that persistedFaceIds will be returned:

https://westus.dev.cognitive.microsoft.com/docs/services/563879b61984550e40cbbe8d/operations/563879b61984550f30395241

I can confirm via usage that the saved Face Ids are not being returned currently.

huxuan commented 7 years ago

Hi @NateRickard, thanks for the reporting.

Seems it is an iOS SDK error, we use persistedFaceId(s) as the face feature need to be stored persistently for further operation. This is different from the faceId(s) returned by Detection API as it will be cached for only 24 hours.

Are you interested in fixing this issue? Feel free to reach me if you have any further problem.

NateRickard commented 7 years ago

Hi @huxuan - yes exactly, just a mismatch in the string keys being returned and what's expected. I also logged #22 which is the same issue more or less.

I'm actually binding this SDK for Xamarin (to open source for others), so I'm not set up to build the Xcode project. I can change the string (since it's a simple change) and send a PR, but I won't be able to build/test natively. So let me know if you want me to do that or if you just want to change the strings quickly.

huxuan commented 7 years ago

Hi @NateRickard, OK, then I will handle this. Feel free to update if you find further tasty bugs. :-)