search

microsoft / CromwellOnAzure

Microsoft Genomics implementation of the Broad Institute's Cromwell workflow engine on Azure
MIT License
135 stars 55 forks source link

Deployer refactor #490

Open BMurri opened 2 years ago

BMurri commented 2 years ago

Problem: The Deployer class is, at this point, a god object, and it's getting worse.

Solution: There are several things happening in the ~3k loc, most of which should be moved into sibling classes.

Describe alternatives you've considered Continuing to add more and more cruft.

Additional context There are some sibling classes now, but there's no consistency in the relationships between the various parts. Some thoughtful design should be brought to bear here so that continued innovations won't be hampered by the difficulty of grokking the mess.

ngambani commented 10 months ago

@BMurri does this problem still exist? or has been resolved/not required anymore?

BMurri commented 10 months ago

It is still needed.