microsoft / Docker-PowerShell

PowerShell Module for Docker
MIT License
289 stars 87 forks source link

Adding TLS verify support & key.pem support. #160

Closed swernli closed 8 years ago

swernli commented 8 years ago

@jstarks @jterry75 With this change, the cmdlets will be able to use the ca.pem/key.pem combination in the same way as the docker CLI, removing the need for generating a separate, Windows-specific PFX. Unforunately, the mechanisms required to make this work are not yet available in .NET Core, so certificate support is Windows only at the moment. Once .NET Core with the latest networking fixes is released, we can unblock that scenario for cross-platform. Pulls in the latest Docker.DotNet to get PEM support.

swernli commented 8 years ago

I hadn't intended to leave that test code in there... it won't really work on anyone else's machine, so it's not a valid test to keep in the product.

jterry75 commented 8 years ago

LGTM. Just remove the "test/src"

swernli commented 8 years ago

@jstarks Is this ready to merge?