microsoft / FluidFramework

Library for building distributed, real-time collaborative web applications
https://fluidframework.com
MIT License
4.74k stars 536 forks source link

refactor: Use assert.equal() to see values when test fails #23172

Closed alexvy86 closed 4 days ago

alexvy86 commented 1 week ago

Description

The Includes ack'd ids in summary test sometimes fails against routerlicious but the error output only says false !== true so we can't tell the actual value of the number that is being compared to 1. This PR updates a few asserts in that file so they'll give us the actual value instead of just expected true, got false in the output when the test fails.

Reviewer Guidance

The review process is outlined on this wiki page.

msfluid-bot commented 1 week ago
@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 467.24 KB 467.27 KB +35 Bytes
azureClient.js 564.01 KB 564.06 KB +49 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 263.43 KB 263.45 KB +14 Bytes
fluidFramework.js 428.84 KB 428.85 KB +14 Bytes
loader.js 134.18 KB 134.19 KB +14 Bytes
map.js 42.71 KB 42.71 KB +7 Bytes
matrix.js 150.15 KB 150.16 KB +7 Bytes
odspClient.js 529.85 KB 529.89 KB +49 Bytes
odspDriver.js 97.88 KB 97.9 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.83 KB +14 Bytes
sharedString.js 166.23 KB 166.24 KB +7 Bytes
sharedTree.js 419.3 KB 419.3 KB +7 Bytes
Total Size 3.38 MB 3.38 MB +245 Bytes

Baseline commit: d94bd42b344f53e3efa2254c8012566e00835ca2

Generated by :no_entry_sign: dangerJS against cecdfe9c8f38065cc13848adef2336dda2e55694