microsoft / FluidFramework

Library for building distributed, real-time collaborative web applications
https://fluidframework.com
MIT License
4.74k stars 536 forks source link

fix(devtools-view): Fix selectable menu section role #23177

Closed Josmithr closed 1 week ago

Josmithr commented 1 week ago

Previous PR attempted to fix this by setting the "button" role via style properties, but apparently this doesn't actually work. Confirmed that the role did not appear in the browser devtools view previously but does with the new pattern.

Also updates styling to highlight selectable menu headers the same way we highlight sub-heading selections.

github-actions[bot] commented 1 week ago

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"

> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  170005 links
    1595 destination URLs
    1825 URLs ignored
       0 warnings
       0 errors
msfluid-bot commented 1 week ago
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 467.24 KB 467.27 KB ⯅ +35 Bytes
azureClient.js 564.01 KB 564.06 KB ⯅ +49 Bytes
connectionState.js 724 Bytes 724 Bytes â–  No change
containerRuntime.js 263.43 KB 263.45 KB ⯅ +14 Bytes
fluidFramework.js 428.84 KB 428.85 KB ⯅ +14 Bytes
loader.js 134.18 KB 134.19 KB ⯅ +14 Bytes
map.js 42.71 KB 42.71 KB ⯅ +7 Bytes
matrix.js 150.15 KB 150.16 KB ⯅ +7 Bytes
odspClient.js 529.85 KB 529.89 KB ⯅ +49 Bytes
odspDriver.js 97.88 KB 97.9 KB ⯅ +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.83 KB ⯅ +14 Bytes
sharedString.js 166.23 KB 166.24 KB ⯅ +7 Bytes
sharedTree.js 419.3 KB 419.3 KB ⯅ +7 Bytes
Total Size 3.38 MB 3.38 MB ⯅ +245 Bytes

Baseline commit: cea34d10d0f816335ab1b88b190940046ae7b696

Generated by :no_entry_sign: dangerJS against d117a42664c9c42a7b91ddc09345aee2ec308113