feat(client-presence): use common event support

microsoft / FluidFramework

Library for building distributed, real-time collaborative web applications

https://fluidframework.com

MIT License

4.74k stars 536 forks source link

feat(client-presence): use common event support #23196

Closed jason-ha closed 3 days ago

jason-ha commented 6 days ago

Use event types from core-interfaces and implementation from client-utils.
Add off event deregistration support.
Rename types following the updates that had been made to "core-interfaces" events.

msfluid-bot commented 6 days ago

⯅ @fluid-example/bundle-size-tests: +245 Bytes

Metric Name	Baseline Size	Compare Size	Size Diff
aqueduct.js	467.08 KB	467.11 KB	⯅ +35 Bytes
azureClient.js	563.85 KB	563.9 KB	⯅ +49 Bytes
connectionState.js	724 Bytes	724 Bytes	■ No change
containerRuntime.js	263.27 KB	263.29 KB	⯅ +14 Bytes
fluidFramework.js	428.71 KB	428.73 KB	⯅ +14 Bytes
loader.js	134.18 KB	134.19 KB	⯅ +14 Bytes
map.js	42.71 KB	42.71 KB	⯅ +7 Bytes
matrix.js	150.15 KB	150.16 KB	⯅ +7 Bytes
odspClient.js	530.45 KB	530.5 KB	⯅ +49 Bytes
odspDriver.js	98.65 KB	98.67 KB	⯅ +21 Bytes
odspPrefetchSnapshot.js	43.04 KB	43.05 KB	⯅ +14 Bytes
sharedString.js	166.23 KB	166.24 KB	⯅ +7 Bytes
sharedTree.js	419.17 KB	419.18 KB	⯅ +7 Bytes
Total Size	3.38 MB	3.38 MB	⯅ +245 Bytes

Baseline commit: fa4a02e5c9be838dfb267649b076c1355ee2b109

Generated by :no_entry_sign: dangerJS against 83e603809af6f0e64b308010f8f71222734270a9

jason-ha commented 3 days ago

closing to nudge stuck "licesnse/cla" check

github-actions[bot] commented 3 days ago

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"

> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  170006 links
    1595 destination URLs
    1825 URLs ignored
       0 warnings
       0 errors