Open alexvy86 opened 4 days ago
🔗 No broken links found! ✅
Your attention to detail is admirable.
> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links
1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"
> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open
[SUCCESS] Serving "build" directory at: http://localhost:3000/
> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt
Crawling...
Stats:
170006 links
1595 destination URLs
1825 URLs ignored
0 warnings
0 errors
@microsoft-github-policy-service rerun
Description
This updates the initial port that test-tools assigns to packages from 8081 to 9000 and makes it configurable.
Motivation
The build of the LTS branch is failing, and as far as I can tell it is due to a combination of two things:
assign-test-ports
executable from@fluidframework/test-tools
has jest tests so it tries to start jest in that port and fails.I imagine this started failing at some point when we made changes to the build infra, but since we're not continuously building the LTS branch, we didn't notice at the time. I even confirmed that running the build pipeline for the last commit in LTS for which it succeeded (May 2024), fails today.
The dependency update is purely opportunistic.
Reviewer Guidance
The review process is outlined on this wiki page.