Can't compile last master on VS2017

microsoft / HoloJS

Provides a framework for creating holographic apps using JavaScript and WebGL.

MIT License

1.19k stars 114 forks source link

Can't compile last master on VS2017 #131

Closed nosy-b closed 6 years ago

nosy-b commented 6 years ago

I have last Win 10 SDK (10.0.16299.91) and I can't compile the last master on VS2017 I could compile the 11th december version (https://github.com/Microsoft/HoloJS/commit/081f2f201b47854317913dda827c56c83292b357) without any problem on VS2017.

Now I have:

EGLBaseCoordinateSystemProperty undeclared
EGL...
Failure #using on ..../HologramJS.winmd

I copied your last angle version.

Do you have any idea?

Thanks!

Almost-Done commented 6 years ago

It looks like you changed the ANGLE submodule to point to holojs/webvr? That won't work without corresponding changes in HoloJS, and those changes are not ready yet. Or maybe

Edit: your ANGLE submodule should be on the holojs/master branch. Use "git checkout holojs/master" to make sure.

nosy-b commented 6 years ago

My bad you're right! I cloned your angle fork and I didn't check that the default branch is ms-master and not holojs/master... It now works perfectly fine thanks Cristi!