[BUG] Services always requests MIDI 2.0 protocol even if the endpoint has not declared MIDI 2.0 protocol compatibility

microsoft / MIDI

Windows MIDI Services

MIT License

301 stars 24 forks source link

[BUG] Services always requests MIDI 2.0 protocol even if the endpoint has not declared MIDI 2.0 protocol compatibility #379

Open Psychlist1972 opened 1 month ago

Psychlist1972 commented 1 month ago

Describe the bug During protocol negotiation, the service always requests MIDI 2.0 protocol, even if the returned endpoint info from discovery shows only MIDI 1.0 compatibility.

Expected behavior The service should try to negotiate MIDI 2.0 protocol only if it is supported. Otherwise, it should negotiate MIDI 1.0 protocol.

If neither is specified, given this is a UMP endpoint, I'm of the opinion that MIDI 2.0 should be the default. Happy to listen to dissenting opinions on this.

MusicMaker commented 1 month ago

Not sure this is a dissenting opinion, but an opinion :-)