microsoft / MMdnn

MMdnn is a set of tools to help users inter-operate among different deep learning frameworks. E.g. model conversion and visualization. Convert models between Caffe, Keras, MXNet, Tensorflow, CNTK, PyTorch Onnx and CoreML.
MIT License
5.8k stars 965 forks source link

The "size" parameter of LRN operator is handled inconsistently. #808

Closed linmajia closed 4 years ago

linmajia commented 4 years ago

Some DL frameworks use "depth_radius" while others use "size". From the formal definition:

  1. size = depth_radius * 2 + 1
  2. depth_radius = size / 2 (rounded down)

This parameter is named by "size" in MMdnn. However, MMdnn handles it inconsistently in supported DL frameworks.

linmajia commented 4 years ago

Fixed in PR https://github.com/microsoft/MMdnn/pull/814 .