search

microsoft / MSIX-PackageSupportFramework

The Package Support Framework (PSF) is a kit for applying compatibility fixes to packaged desktop applications.
MIT License
114 stars 57 forks source link

PSF crashes initializing when config.json has improper regex patterns. #161

Closed TimMangan closed 1 year ago

TimMangan commented 3 years ago

Both the FileRedirectionFixup and RegLegacyFixup crash when initializing is bad regex patters are provided in the config.json file.

For example, the FRF calls pattern.assign in the InitializeConfiguration section unprotected.

Passing a string like .\xml instead of the correct syntax .\.xml causes the crash.

This code should be protected and bad patterns ignored after logging.

TimMangan commented 3 years ago

Potential fix added into my fork. The offender is caught a logged and the fixups otherwise ignore the bad entry.

npuvvada commented 1 year ago

This issue is fixed from PSF release : version 1.0.220926.1